Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sentinel_alert_rule_fusion - support for sourceblock #19093

Merged
merged 4 commits into from
Nov 6, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Nov 2, 2022

Add new property source_setting for azurerm_sentinel_alert_rule_fusion.

In my first try, I've omit the enabled properties in the schema (see: 383de98). Due to the API issue Azure/azure-rest-api-specs#21387, it won't work.

Test

💢  TF_ACC=1 go test -v -timeout=20h ./internal/services/sentinel -run=TestAccSentinelAlertRuleFusion_
=== RUN   TestAccSentinelAlertRuleFusion_basic
=== PAUSE TestAccSentinelAlertRuleFusion_basic
=== RUN   TestAccSentinelAlertRuleFusion_disable
=== PAUSE TestAccSentinelAlertRuleFusion_disable
=== RUN   TestAccSentinelAlertRuleFusion_sourceSetting
=== PAUSE TestAccSentinelAlertRuleFusion_sourceSetting
=== RUN   TestAccSentinelAlertRuleFusion_requiresImport
=== PAUSE TestAccSentinelAlertRuleFusion_requiresImport
=== CONT  TestAccSentinelAlertRuleFusion_basic
=== CONT  TestAccSentinelAlertRuleFusion_sourceSetting
=== CONT  TestAccSentinelAlertRuleFusion_requiresImport
=== CONT  TestAccSentinelAlertRuleFusion_disable
--- PASS: TestAccSentinelAlertRuleFusion_basic (185.42s)
--- PASS: TestAccSentinelAlertRuleFusion_requiresImport (230.13s)
--- PASS: TestAccSentinelAlertRuleFusion_sourceSetting (234.34s)
--- PASS: TestAccSentinelAlertRuleFusion_disable (258.68s)
PASS

Optional: true,
Default: true,
},
"enabled_severities": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be

Suggested change
"enabled_severities": {
"severities_enabled": {

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte We used foo_enabled as a boolean property, whilst this one is an array of enabled severities.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but putting it in front doesn't make sense. looking at the api closer, should this just be

Suggested change
"enabled_severities": {
"severities": {

as it is the severities for this sub_type, so sub_type.enable = true means enable then, sub_type.enabled = false would actually disable them?

so maybe

Suggested change
"enabled_severities": {
"severities_allowed": {

or

Suggested change
"enabled_severities": {
"severities_filter": {

Copy link
Collaborator Author

@magodo magodo Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte I see. I've renamed it to severities_allowed now.

@magodo
Copy link
Collaborator Author

magodo commented Nov 3, 2022

@katbyte Properties are renamed, please take another look!

Optional: true,
Default: true,
},
"enabled_severities": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but putting it in front doesn't make sense. looking at the api closer, should this just be

Suggested change
"enabled_severities": {
"severities": {

as it is the severities for this sub_type, so sub_type.enable = true means enable then, sub_type.enabled = false would actually disable them?

so maybe

Suggested change
"enabled_severities": {
"severities_allowed": {

or

Suggested change
"enabled_severities": {
"severities_filter": {

@katbyte katbyte changed the title azurerm_sentinel_alert_rule_fusion - support for source_setting azurerm_sentinel_alert_rule_fusion - support for sourceblock Nov 6, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks @magodo LGTM :atom:

@katbyte katbyte merged commit 7739efe into hashicorp:main Nov 6, 2022
@github-actions github-actions bot added this to the v3.31.0 milestone Nov 6, 2022
katbyte added a commit that referenced this pull request Nov 6, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions
Copy link

This functionality has been released in v3.31.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants